Fix intercept initialization for multinomial logistic objective #11786
+18
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not sure how to handle the GPU segfaults. Perhaps some maintainer could take over. |
Member
|
Thank you for working on this. I will look into it. |
trivialfis
force-pushed
the
fix_mnlogit_intercepts
branch
from
d731886 to
229b836
Compare
trivialfis
force-pushed
the
fix_mnlogit_intercepts
branch
from
229b836 to
6bb3a5d
Compare
Member
|
I fixed the GPU access for the PR. But still need to go through all the failing CPU tests. |
david-cortes
commented
Nov 12, 2025
src/objective/multiclass_obj.cu
Outdated
| common::Mean(this->ctx_, *base_score, &mean_intercepts); | ||
| auto d_mean = mean_intercepts.View(this->ctx_->Device()); | ||
| TransformKernel(this->ctx_, intercept, | ||
| [=] XGBOOST_DEVICE(float v) { return log(v) - d_mean(0); }); |
Contributor
Author
There was a problem hiding this comment.
It'd make more sense to take the mean after applying logarithms, so that they would end up summing to zero, the same way as other libraries handle it.
Member
There was a problem hiding this comment.
Yes, I will handle that. Thank you for pointing out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11763