Skip to content

Conversation

@Emmankoko
Copy link
Contributor

@Emmankoko Emmankoko commented Oct 24, 2025

In an attempt to fix #define identifier identifier not being resolvable in D,
we create D aliases for these macros that refer to identifiers.
including a case check for identifiers actually caused conflicts with most of the inbuilt C compiler macros
because of them define to identifiers and some are actually having no good use
like macros that defines the same name eg. (#define if if) very common in C libs and headers.
since they break D semantics, we do not allow it to break D semantics by just ignoring them
like we have been doing.
For now, I have kept a small table of symbols that easily conflicts but I think we can handle these well to integrate fully

we get to be able import macros that point to identifiers in D whiles not getting interfered by C builtins which
D doesn't know.

more work needs to be done accordingly to win against C macro system fully.

@dkorpel

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 24, 2025

Thanks for your pull request and interest in making D better, @Emmankoko! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22022"

@Emmankoko Emmankoko force-pushed the macro branch 4 times, most recently from 8ef4b89 to 490f9a5 Compare October 25, 2025 19:27
@Emmankoko Emmankoko changed the title Attempt to fix #20410 Attempt to fix #20410 and #20478 Oct 28, 2025
@thewilsonator
Copy link
Contributor

This is green, is it good to go?

@Emmankoko Emmankoko force-pushed the macro branch 2 times, most recently from 00b65fd to 97f4eeb Compare October 29, 2025 11:35
@Emmankoko
Copy link
Contributor Author

This is green, is it good to go?

nope.

want to fix most of the macros issues in this PR. so I'm tracking all.

This could not make the two states of the macro in dlang#20194
workable.
@Emmankoko Emmankoko changed the title Attempt to fix #20410 and #20478 Attempt to fix all Macro issues Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants