There seems to be no way to disable collector recycling

[sandersaares]

Recycling collectors can apparently crash .NET 6.0 runtime:

• [release/6.0] Delete dangling thread session states dotnet/runtime#76431
• EventPipe sessions can leak the EventPipeThreadSessionState* associated with them dotnet/runtime#76430

I would therefore like to disable recycling. If I understand it right, the recycling is no longer necessary with .NET 6.0 anyway, right? (Based on comments in dotnet/runtime#43985)

However, it seems that there is no option for this! RecycleCollectorsEvery() does not accept a null/zero parameter. I request that this option be added and/or recycling be disabled from 6.0 onwards if it is no longer relevant.

[djluck]

Interesting, thanks for the research @sandersaares. If this is the case then yeah, let's go with disabling recycling for .NET 6.0 (from memory this would leave it only enabled for .NET 5.0). I can submit an MR later this week or so.

[djluck]

Hey @sandersaares, I just double checked and by default recycling isn't enabled for any runtime (although you can choose to enable it via RecycleCollectorsEvery).

[sandersaares]

It seems to default to 24 hours here for net50:

prometheus-net.DotNetRuntime/src/prometheus-net.DotNetRuntime/DotNetRuntimeStatsCollector.cs

Line 205 in aa9fb94

TimeSpan.FromDays(1);

Am I misreading the code somehow? Seems to match what I observe happening.

[djluck]

Apologies, I missed that (it's been a while since I've looked at this code!). I've just published v4.3.0 which targets .net60 and as a result, should see collector recycling only enabled by default for .net50.

[sandersaares]

Thanks! I confirm this seems to fix it.