Skip to content

Conversation

@jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 12, 2025

@djc
Copy link
Owner

djc commented Oct 13, 2025

Is there something we could do in CI to catch this?

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.88%. Comparing base (d7575cc) to head (0d3a8dd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #264   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files           6        6           
  Lines         633      633           
=======================================
  Hits          512      512           
  Misses        121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 13, 2025

Use cargo-nextest to run the tests?

@djc djc merged commit 7d13fe2 into djc:main Oct 13, 2025
10 checks passed
@djc
Copy link
Owner

djc commented Oct 13, 2025

Use cargo-nextest to run the tests?

I don't really want to pull that extra complexity into CI.

@djc djc changed the title redis: Fix conditional compilation of portable-atomic Fix conditional compilation of portable-atomic Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants