Skip to content

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Oct 12, 2025

Copy link

codecov bot commented Oct 12, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 80.88%. Comparing base (7d13fe2) to head (8234268).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
redis/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   80.88%   80.88%           
=======================================
  Files           6        6           
  Lines         633      633           
=======================================
  Hits          512      512           
  Misses        121      121           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@djc
Copy link
Owner

djc commented Oct 12, 2025

I don't think a Cargo feature makes sense for this, but I'm open to publishing a bb8-redis rc release that depends on the redis 1 rc.

@jayvdb
Copy link
Contributor Author

jayvdb commented Oct 12, 2025

I'm open to publishing a bb8-redis rc release that depends on the redis 1 rc.

Thanks. The code change here is trivial, so im happy for you to go ahead and create an -rc release using a different approach.

@djc
Copy link
Owner

djc commented Oct 13, 2025

Can you make the following changes to the PR:

  • Bump the bb8-redis version to 0.25.0-rc.1
  • Update the redis dependency to 1.0.0-rc.1 (no range)
  • Add whatever changes to make it compile

@jayvdb jayvdb changed the title redis: Add redis-1 feature to support redis v1.0.0-rc redis: Support redis v1.0.0-rc Oct 14, 2025
@djc djc merged commit b34c071 into djc:main Oct 14, 2025
9 of 10 checks passed
@djc
Copy link
Owner

djc commented Oct 14, 2025

Published.

@jayvdb jayvdb deleted the redis-1.0 branch October 14, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants