Skip to content

Conversation

JadielTeofilo
Copy link
Contributor

Fixes #

Description of the Change

Fixes #524. Restrict usage of timezone aware expire dates to Django projects with USE_TZ set to True.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@auvipy auvipy requested a review from n2ygk March 21, 2021 09:12
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the test failures

@codecov
Copy link

codecov bot commented Mar 21, 2021

Codecov Report

Merging #948 (921cef6) into master (5d53d24) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #948   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          31       31           
  Lines        1704     1704           
=======================================
  Hits         1646     1646           
  Misses         58       58           
Impacted Files Coverage Δ
oauth2_provider/oauth2_validators.py 93.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d53d24...921cef6. Read the comment docs.

@JadielTeofilo JadielTeofilo requested a review from auvipy March 21, 2021 16:47
@n2ygk n2ygk added this to the 1.5.1 milestone Mar 22, 2021
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@n2ygk n2ygk merged commit 39a4577 into master Mar 22, 2021
@n2ygk n2ygk deleted the fix-issue-524 branch March 22, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token introspection always uses time-zone-aware datetimes
3 participants