Fix DeprecationWarnings by updating key type property usage in tests #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Subham-KRLX for context, can you link to the documentation regarding the deprecation of key_type here in the issue? |
|
Hi @dopry, this change is based on the official JSON Web Key spec (RFC 7517, Section 4.1) which mandates "kty" as the standard parameter for key type. The older key_type property in libraries like jwcrypto has been deprecated and now triggers warnings with .kty being the correct standards-compliant attribute. Updating the tests removes these DeprecationWarnings ensures compatibility with the latest dependencies and aligns with the JWK specification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1483.
Replaced deprecated key.key_type with key.kty in test files to remove DeprecationWarnings and ensure compatibility with latest dependencies.
Single change (remove DeprecationWarnings).