Skip to content

Fix documentation regarding rotate_refresh_token setting #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Fix documentation regarding rotate_refresh_token setting #1250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41fc5f1
documentation seems to be outdated regarding rotate_refresh_token set…
JordiNeil Feb 11, 2023
34a8b9f
Merge branch 'master' into fix-rotate-refresh-token-documentation
n2ygk Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/settings.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ this value if you wrote your own implementation (subclass of
ROTATE_REFRESH_TOKEN
~~~~~~~~~~~~~~~~~~~~
When is set to `True` (default) a new refresh token is issued to the client when the client refreshes an access token.
Known bugs: `False` currently has a side effect of immediately revoking both access and refresh token on refreshing.
If `False`, it will reuse the same refresh token and only update the access token with a new token value.
See also: validator's rotate_refresh_token method can be overridden to make this variable
(could be usable with expiring refresh tokens, in particular, so that they are rotated
when close to expiration, theoretically).
Expand Down