Replace RST header underline with one that pre-commit check-merge won't break on. #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1057 +/- ##
=======================================
Coverage 96.64% 96.64%
=======================================
Files 31 31
Lines 1756 1756
=======================================
Hits 1697 1697
Misses 59 59 ☔ View full report in Codecov by Sentry. |
n2ygk
force-pushed
the
fix_pre_commit_authors
branch
from
8b040ee to
b16b285
Compare
Andrew-Chen-Wang
approved these changes
Dec 24, 2021
n2ygk
added a commit
that referenced
this pull request
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description of the Change
Workaround problem where the precommit merge hook breaks on the 7-character doulbe-underline for AUTHORS by having a false-positive broken commit error.
It pains me to do this but I'd rather catch actual merge conflicts than exclude checking this file.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS