-
Notifications
You must be signed in to change notification settings - Fork 809
Removes default_app_config for Django Deprecation Warning #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -1,3 +1 @@ | |||
__version__ = "1.5.0" | |||
|
|||
default_app_config = "oauth2_provider.apps.DOTConfig" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #1035 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 31 31
Lines 1746 1748 +2
=======================================
+ Hits 1687 1689 +2
Misses 59 59
Continue to review full report at Codecov.
|
not sure 3.6 is failing |
It passes locally for me:
But if I don't have django installed in the environment where tox is being run, it fails with the same error. |
@auvipy Can you run the build for that and see if it works? |
started. was in vacation |
can you check the py3.8 failure please? |
3.8 is failing because it's the only one that runs I found it's because I pinned it to |
Description of the Change
Fixes Django Deprecation Warning
/usr/local/lib/python3.9/site-packages/django/apps/registry.py:91: RemovedInDjango41Warning: 'oauth2_provider' defines default_app_config = 'oauth2_provider.apps.DOTConfig'. Django now detects this configuration automatically. You can remove default_app_config.
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS
Confirmed that tox passed locally