Skip to content

Removes default_app_config for Django Deprecation Warning #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 10, 2021

Conversation

pcarn
Copy link
Contributor

@pcarn pcarn commented Nov 27, 2021

Description of the Change

Fixes Django Deprecation Warning
/usr/local/lib/python3.9/site-packages/django/apps/registry.py:91: RemovedInDjango41Warning: 'oauth2_provider' defines default_app_config = 'oauth2_provider.apps.DOTConfig'. Django now detects this configuration automatically. You can remove default_app_config.

Checklist

  • PR only contains one change (considered splitting up PR)
  • N/A unit-test added
  • N/A documentation updated
  • N/A CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Confirmed that tox passed locally

@@ -1,3 +1 @@
__version__ = "1.5.0"

default_app_config = "oauth2_provider.apps.DOTConfig"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@pcarn pcarn Nov 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #1035 (a6fcd37) into master (401d856) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files          31       31           
  Lines        1746     1748    +2     
=======================================
+ Hits         1687     1689    +2     
  Misses         59       59           
Impacted Files Coverage Δ
oauth2_provider/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 401d856...a6fcd37. Read the comment docs.

@pcarn pcarn requested a review from auvipy November 27, 2021 05:05
@auvipy
Copy link
Contributor

auvipy commented Nov 27, 2021

not sure 3.6 is failing

@pcarn
Copy link
Contributor Author

pcarn commented Nov 27, 2021

It passes locally for me:

_______________________________________________________ summary ________________________________________________________
  py36-dj32: commands succeeded
  py36-dj31: commands succeeded
  py36-dj22: commands succeeded
  congratulations :)

But if I don't have django installed in the environment where tox is being run, it fails with the same error.

@pcarn
Copy link
Contributor Author

pcarn commented Nov 27, 2021

@auvipy I think the fix would be to install django before running tox, which I added in d49e52a.

Let me know if that's fine.

@pcarn
Copy link
Contributor Author

pcarn commented Dec 7, 2021

@auvipy Can you run the build for that and see if it works?

@auvipy
Copy link
Contributor

auvipy commented Dec 10, 2021

started. was in vacation

@auvipy
Copy link
Contributor

auvipy commented Dec 10, 2021

can you check the py3.8 failure please?

@pcarn
Copy link
Contributor Author

pcarn commented Dec 10, 2021

3.8 is failing because it's the only one that runs tox -e docs.
When I try locally, the same failure happens on the master branch.

I found it's because m2r has mistune unpinned, and they released breaking changes.

I pinned it to <2, and it works locally now.
pcarn@a6fcd37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants