Feat/subsquid datasource #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d working sequencer
…ion / FunctionInvocation / FeeTransferInvocation placing. TBD in newest blocks
aopoltorzhicky
requested changes
Feb 19, 2025
pkg/indexer/indexer.go
Outdated
|
|
||
| func (indexer *Indexer) getNewBlocks(ctx context.Context) error { | ||
| head, err := indexer.receiver.Head(ctx) | ||
| commonReceiver, ok := indexer.receiver.(*receiver.Receiver) |
There was a problem hiding this comment.
Как будто эту проверку можно перенести в начало sync метода. getNewBlocks только там и вызывается
| return traces, nil | ||
| } | ||
|
|
||
| func getTxTraces(traces []api.TraceResponse, txIndex uint) []api.TraceResponse { |
There was a problem hiding this comment.
Как ни странно, но здесь могут помочь итераторы =) не уверен, что будет выглядеть чище, но можешь посмотреть при желании
|
|
||
| for invokationIndex := range flatInvocations { | ||
| invocation := flatInvocations[invokationIndex] | ||
| calldata := make([]data.Felt, len(invocation.Calldata)) |
There was a problem hiding this comment.
можно сделать какую-нибудь вспомогательную функцию для перевода []string -> []data.Felt. Часто встречается
| return current | ||
| } | ||
|
|
||
| func filterEventsByAddress(events []api.Event, targetAddress []int) []api.Event { |
There was a problem hiding this comment.
тоже очень похоже на итераторы
| return response.Body().AsString() | ||
| } | ||
|
|
||
| func (s *Subsquid) GetBlocks(_ context.Context, from, to uint64, workerUrl string) ([]*SqdBlockResponse, error) { |
There was a problem hiding this comment.
Используй контекст workerClient.Context().Set()
| import "github.com/dipdup-io/starknet-go-api/pkg/data" | ||
|
|
||
| func (block *SqdBlockResponse) GetDeployContractAddress(txIndex uint) data.Felt { | ||
| for _, trace := range block.Traces { |
There was a problem hiding this comment.
Сделай итерацию по индексу лучше
| if value == nil { | ||
| return "" | ||
| } | ||
| return data.Felt(fmt.Sprintf("%d", *value)) |
There was a problem hiding this comment.
вроде через %x надо сделать
# Conflicts: # go.mod # go.sum
…o hex string repr.
aopoltorzhicky
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.