- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.3k
 
Open
Labels
Description
https://github.com/dingo/api/blob/master/src/Http/Response.php#L174
    /**
     * {@inheritdoc}
     */
    public function setContent($content)
    {
        try {
            return parent::setContent($content);
        } catch (UnexpectedValueException $exception) {
            $this->original = $content;
            return $this;
        }
    }
https://github.com/dingo/api/blob/master/src/Http/Response.php#L80
public static function makeFromExisting(IlluminateResponse $old)
    {
        $new = static::create($old->getOriginalContent(), $old->getStatusCode());
        $new->headers = $old->headers;
        return $new;
    }
https://github.com/dingo/api/blob/master/src/Http/Response.php#L112
 public function morph($format = 'json')
    {
        $this->content = $this->getOriginalContent();
        ...
   }
If $content is a eloquent model instance, it will be encoded twice before it be overridden by transformer. Three times encoding for for each response, It is a big problem, right ?