Skip to content

Improved Zeroize impl for BigInt's Sign #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Improved Zeroize impl for BigInt's Sign #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/bigint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,15 @@ pub enum Sign {
Plus,
}

#[cfg(feature = "zeroize")]
impl Zeroize for Sign {
fn zeroize(&mut self) {
// TODO: Figure out how to better clear the sign.
*self = Sign::NoSign;
impl Default for Sign {
fn default() -> Sign {
Sign::NoSign
}
}

#[cfg(feature = "zeroize")]
impl zeroize::DefaultIsZeroes for Sign {}

impl Neg for Sign {
type Output = Sign;

Expand Down