Skip to content

Update helm setup docs #2040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2025
Merged

Update helm setup docs #2040

merged 1 commit into from
Jul 23, 2025

Conversation

ZIJ
Copy link
Contributor

@ZIJ ZIJ commented Jul 23, 2025

No description provided.

@ZIJ ZIJ merged commit 954cd10 into develop Jul 23, 2025
11 checks passed
Copy link
Contributor

bismuthdev bot commented Jul 23, 2025

Bismuth encountered an error

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR transforms the Helm deployment documentation from a basic configuration reference into a comprehensive step-by-step deployment guide. The changes restructure the content to provide a better user experience by adding clear prerequisites, step-by-step guidance, and production-ready configuration examples.

Key improvements include:

  • Updated Helm installation commands using the OCI registry format
  • Enhanced configuration examples with explicit production vs testing guidance
  • New sections covering secrets management, database configuration options, and GitHub App setup
  • Improved formatting using MDX components for better readability
  • Complete values.yaml example showcasing all configuration options

The documentation now follows a logical workflow that separates initial deployment from GitHub App configuration, which better matches the actual user experience. This change reflects the product's maturation and targets enterprise users who need detailed deployment guidance for production environments.

Confidence score: 3/5

  • This PR appears safe to merge as it only updates documentation without affecting application code.
  • The score reflects potential inconsistencies between documented configuration examples and actual Helm chart structure that could confuse users.
  • The docs/ce/self-host/deploy-helm.mdx file needs verification to ensure all configuration examples match the actual Helm chart values.yaml structure.

1 file reviewed, 2 comments

Edit Code Review Bot Settings | Greptile

Comment on lines +53 to +65
httpBasicAuthUsername: "admin"
httpBasicAuthPassword: "<strong-password>"
bearerAuthToken: "<strong-token>"
hostname: "digger.example.com"

# GitHub App credentials (filled after setup)
githubOrg: ""
githubAppID: "" # Note: uppercase ID
githubAppClientID: ""
githubAppClientSecret: ""
githubAppKeyFile: "" # base64 encoded private key
githubWebhookSecret: ""
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The secret key names in the documentation (camelCase) don't match the actual Helm chart expectations (UPPER_CASE with underscores). For example, the chart expects 'GITHUB_APP_ID' but the docs show 'githubAppID'.

Comment on lines +92 to +93
secret:
postgresPassword: "<test-password>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The nested 'secret' structure under 'postgres' doesn't match the actual chart structure which expects 'postgres.secret.password' not 'postgres.secret.postgresPassword'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant