Skip to content

feat/app urls #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

feat/app urls #2028

merged 2 commits into from
Jul 18, 2025

Conversation

motatoes
Copy link
Contributor

  • use correct url in notifications
  • fix urls

@motatoes motatoes merged commit fd83543 into develop Jul 18, 2025
11 of 12 checks passed
Copy link
Contributor

bismuthdev bot commented Jul 18, 2025

Bismuth encountered an error

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR modifies how application URLs are handled in Slack notifications within the drift notification system. The key changes:

  1. Replaces hardcoded base URL 'driftapp.digger.dev' with an environment variable DIGGER_APP_URL
  2. Updates URL path pattern from '/project/{id}' to '/dashboard/projects/{id}'
  3. Implements these changes consistently across both test and production notification code paths

This change improves the system's flexibility by allowing different URLs for different environments (dev, staging, prod) through environment variable configuration rather than hardcoding.

Confidence score: 4/5

  1. This PR is safe to merge with proper environment variable configuration
  2. The changes are straightforward URL updates with a clear pattern and purpose
  3. Files needing attention:
    • ee/drift/controllers/notifications.go - Ensure DIGGER_APP_URL is properly set in all environments

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link

delve-auditor bot commented Jul 18, 2025

No security or compliance issues detected. Reviewed everything up to 48aa9b0.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Other ► Unknown files
    Fix URLs

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant