-
Notifications
You must be signed in to change notification settings - Fork 561
use debug logs during create project status #2015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe logging level for messages about project creation in the Changes
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ No security or compliance issues detected. Reviewed everything up to e4e4fd6. Security Overview
Detected Code Changes
Reply to this PR with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
libs/digger_config/terragrunt/atlantis/generate.go (1)
808-814
: Log level lowered to Debug – ensure consistency with “Updated project” logSwitching the “Created project” message from
Info
toDebug
will reduce noise, 👍.
However, the corresponding “Updated project” message (line 800) is still logged atInfo
. If the intent is to keep creation messages quiet, the update path probably deserves the same treatment for symmetry and to avoid an unintentionally lopsided log stream.- slog.Info("Updated project", "path", terragruntPath) + slog.Debug("Updated project", "path", terragruntPath)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
libs/digger_config/terragrunt/atlantis/generate.go
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Build
- GitHub Check: Build
- GitHub Check: Build
- GitHub Check: Build
- GitHub Check: Build
- GitHub Check: Build
- GitHub Check: Build
- GitHub Check: Security Check
- GitHub Check: Build
- GitHub Check: Build
- GitHub Check: Build
🔇 Additional comments (1)
libs/digger_config/terragrunt/atlantis/generate.go (1)
846-849
: Debug-level HCL-project creation log looks goodThe change to
slog.Debug
here matches the new logging granularity and keeps output consistent with the branch above. No further action required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Modified logging levels in Terragrunt parser to reduce verbosity by downgrading project creation status logs from Info to Debug level.
- Changed log level in
libs/digger_config/terragrunt/atlantis/generate.go
from Info to Debug for project creation status, improving operational clarity by reducing non-critical log noise
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
Summary by CodeRabbit