feat: localise multi-calendar fixed periods according to user locale #1432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabaros
changed the title
kabaros
force-pushed
the
localise-periods
branch
from
cbd1671 to
5785efd
Compare
This comment was marked as outdated.
This comment was marked as outdated.
kabaros
force-pushed
the
localise-periods
branch
2 times, most recently
from
736edbe to
fdfdb17
Compare
kabaros
force-pushed
the
localise-periods
branch
from
fdfdb17 to
c640c90
Compare
HendrikThePendric
approved these changes
Feb 23, 2023
Contributor
|
🎉 This PR is included in version 24.5.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
|
🎉 This PR is included in version 24.9.0-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-14678
dhis2/data-visualizer-app#2233
Key features
Description
This PR changes period generation logic to pass the locale along the calendar type to allow localise the generated fixed periods in the requested calendar, as well as the locale
BREAKING CHANGE
no breaking change
Screenshots