Skip to content

Polymorphic entrypoints #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2023
Merged

Polymorphic entrypoints #2544

merged 2 commits into from
Oct 25, 2023

Conversation

@mmhat
Copy link
Collaborator

@mmhat mmhat commented Oct 25, 2023

This PR allows some of the new entrypoints (parseWithSettings, typecheckWithSettings and expectWithSettings) to run in pure code by replacing the IO with a more general monad m that is constrained by MonadThrow.

I also added a new entrypoint checkWithSettings: It is similar to expectWithSettings but does not require a whole Decoder but takes the expected type as expression instead.

@mmhat mmhat requested a review from Gabriella439 October 25, 2023 12:31
@Gabriella439 Gabriella439 merged commit 251cfe7 into dhall-lang:main Oct 25, 2023
@Gabriella439
Copy link
Collaborator

Gabriella439 commented Oct 25, 2023

Thank you for doing this!

@mmhat mmhat deleted the polymorphic-entrypoints branch October 25, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriella439 Gabriella439 Awaiting requested review from Gabriella439

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmhat @Gabriella439