Skip to content

Conversation

@mmhat
Copy link
Collaborator

@mmhat mmhat commented Dec 29, 2022

This PR adds variants for the functions found in the Dhall.Freeze module that also take a context and a normalizer. Those functions are prefixed with custom in order to maintain backwards compatibility. Code common to the existing functions and the new ones were moved to a bunch of helper functions such that there is no unnecessary code duplication.

@Gabriella439
Copy link
Collaborator

Maybe these could take an EvaluateSettings since that has what we need (and some other useful stuff, too)

Copy link
Collaborator

@Gabriella439 Gabriella439 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! This looks amazing. Thank you for doing this

@Gabriella439 Gabriella439 merged commit f9f0641 into dhall-lang:master Jan 5, 2023
@mmhat mmhat deleted the customizable-freeze branch January 11, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants