dhall: Add Data instance to Import
#2462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackKelly-Bellroy
force-pushed
the
import-data-instances
branch
from
b702fc0 to
b502f14
Compare
Gabriella439
approved these changes
Oct 12, 2022
Collaborator
Gabriella439
left a comment
Gabriella439
left a comment
There was a problem hiding this comment.
This looks great to me! I wasn't sure if you had any other changes in mind because this is still marked as a draft PR
Contributor
Author
|
I created it as draft so I could get a PR number to put into the changelog, then forgot to mark it as ready for review. It should be good to go now. |
Collaborator
|
Awesome! Thank you for contributing this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows (among other things) the rewriting of Dhall expressions that contain imports, using the tools in
Data.Data.Lens.