Report input name in parsing errors #2195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basile-henry
commented
May 25, 2021
TristanCacqueray
approved these changes
May 25, 2021
Collaborator
TristanCacqueray
left a comment
TristanCacqueray
left a comment
There was a problem hiding this comment.
Thanks, that is looking good to me.
Collaborator
|
@basile-henry: Thank you for fixing that! 🙂 |
SiriusStarr
reviewed
May 25, 2021
Collaborator
SiriusStarr
left a comment
SiriusStarr
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the quick fix. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2194
Parser errors in
format,freeze,lintdidn't report which input they came from. This wasn't an issue until we started supporting multiple inputs.