feat: ArgoCD v2.13.3 support for private chart providers #6766
Conversation
prkhrkat
requested review from
vikramdevtron,
nishant-d,
prakarsh-dt and
vivek-devtron
as code owners
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
Changelist by BitoThis pull request implements the following key changes.
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #0715af
Actionable Suggestions - 1
-
pkg/appStore/installedApp/service/FullMode/deployment/InstalledAppGitOpsService.go - 1
- Critical null pointer dereference bug · Line 90-92
Additional Suggestions - 1
-
pkg/deployment/gitOps/git/GitOperationService.go - 1
-
Incorrect error logging parameter · Line 314-314The error log is incorrectly logging `targetRevision` as the URL instead of `gitRepoUrl`. This will make debugging difficult as the logged URL will be a revision string instead of the actual repository URL. Please change to log `gitRepoUrl`.
Code suggestion
@@ -314,1 +314,1 @@ - impl.logger.Errorw("error in cloning repo", "url", targetRevision, "err", err) + impl.logger.Errorw("error in cloning repo", "url", gitRepoUrl, "err", err)
-
Review Details
-
Files reviewed - 10 · Commit Range:
2428b40..2428b40- cmd/external-app/wire_gen.go
- internal/util/ChartTemplateService.go
- pkg/appStore/bean/bean.go
- pkg/appStore/installedApp/adapter/Adapter.go
- pkg/appStore/installedApp/service/FullMode/deployment/InstalledAppGitOpsService.go
- pkg/appStore/installedApp/service/bean/bean.go
- pkg/appStore/installedApp/service/common/AppStoreDeploymentCommonService.go
- pkg/deployment/gitOps/git/GitOperationService.go
- pkg/deployment/manifest/deploymentTemplate/chartRef/ChartRefService.go
- pkg/deployment/manifest/deploymentTemplate/chartRef/bean/bean.go
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at [email protected].
Documentation & Help
AI Code Review powered by
pkg/appStore/installedApp/service/FullMode/deployment/InstalledAppGitOpsService.go
Outdated
Show resolved
Hide resolved
|
|
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
Ash-exp
changed the title
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP 404).\n |
github-actions
bot
added
PR:Ready-to-Review
and removed
PR:Issue-verification-failed
labels
Code Review Agent Run #1d9bceActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
…arison in GitOps operations
…ed chart metadata and remove requirements.yaml checks
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 19465121 | Triggered | Generic High Entropy Secret | 416558b | scripts/sql/34304100_bulk_edit_config.up.sql | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
|
Bito Automatic Review Skipped - Files Excluded |
flux ns missing fix
|
Description
Fixes #6736
Checklist:
Does this PR introduce a user-facing change?
Summary by Bito
This PR updates the GitOps service to support ArgoCD v2.13.3, enhancing chart metadata handling, improving validation processes, and removing outdated dependencies for better stability and functionality. It also modifies method signatures to include new parameters for enhanced error handling.