Fix support for platform-suffixed build output #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that the new-ish platform-suffixed TF names (i.e. net7.0-windows, net7.0-maccatalyst and so on) all end up being the same TFM (.NETCoreApp, Version=7.0), which ends up packing assets to duplicate package paths in pack inference. It seems like we might need to rethink nugetier reliance on the TFM for most of its multi-targeting and TF-specific packing. We currently use the TFM as the default to determine target package path, unless a TF is specified for an item. This ends up being incorrect if the TF contains a platform suffix, as noted. For now, provide a specific and localized fix for just primary output assembly, symbols and docs. We should do an extensive examination of other scenarios for xplat MAUI packages.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that the new-ish platform-suffixed TF names (i.e. net7.0-windows, net7.0-maccatalyst and so on) all end up being the same TFM (.NETCoreApp, Version=7.0), which ends up packing assets to duplicate package paths in pack inference.
It seems like we might need to rethink nugetier reliance on the TFM for most of its multi-targeting and TF-specific packing. We currently use the TFM as the default to determine target package path, unless a TF is specified for an item. This ends up being incorrect if the TF contains a platform suffix, as noted.
For now, provide a specific and localized fix for just primary output assembly, symbols and docs.
We should do an extensive examination of other scenarios for xplat MAUI packages.