Skip to content

Conversation

@patrickhulce
Copy link
Contributor

5556015 seems to have broken the tests & handling of whitespace

with the way the regex is now it will never match anything since \s is part of the character class in the next group, so from what I can tell we can either remove \s*? entirely to not trim whitespace, throw or .trim on the value, or do something like I've done here

also added a test case for #60

Copy link
Owner

@developit developit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants