Skip to content

Support: javascript-node 24 #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 17, 2025
Merged

Conversation

Marukome0743
Copy link
Contributor

@Marukome0743 Marukome0743 commented May 29, 2025

Summary

Introduce Node.js 24 on both Debian Bookworm and Bullseye, make it the default variant, and update documentation and tag configurations accordingly.

New Features:

  • Add support for Node.js 24 variants (24-bookworm and 24-bullseye) in the JavaScript Node image

Enhancements:

  • Promote 24-bookworm to the default (latest) variant
  • Update variant tag mappings and supported architectures for all Debian variants
  • Refresh README to include new 24 variants and adjust sample image tag examples
  • Bump the default VARIANT in the devcontainer Dockerfile to 24-bookworm

@Marukome0743 Marukome0743 requested a review from a team as a code owner May 29, 2025 05:55
@Marukome0743
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Marukome0743 Marukome0743 force-pushed the pr1423 branch 2 times, most recently from 2dc9b34 to 714baa8 Compare June 2, 2025 00:38
@haltcase
Copy link

Just curious, is this blocked by anything in particular, such as v24 becoming LTS? Or is it simply waiting for availability to review?

## Summary

Add Node.js 24 support to JavaScript and TypeScript devcontainer images and update defaults and documentation accordingly.

New Features:
- Add support for Node.js 24 variants (24-bookworm and 24-bullseye) in both javascript-node and typescript-node images

Enhancements:
- Set the default 'latest' variant and devcontainer ARG to 24-bookworm

Build:
- Update manifest.json files to include new 24 variants with architectures and variantTags

Documentation:
- Update README files to list and reference the new 24 image tags and adjust security patching examples
Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a reply to #1423 (comment)
(Disclaimer: it is late and I am relatively new to the org)
It seems like there is a need for the JS version to be published before we can move onto the typescript variant. What I will ask you to do is: remove all Typescript changes, we will publish the JS ones and then make another PR for TS which we can deal with once the former has been merged and released (I will do by EOD Monday).

@Marukome0743 Marukome0743 changed the title Support: javascript-node 24 and typescript-node 24 Support: javascript-node 24 Jun 12, 2025
@Marukome0743
Copy link
Contributor Author

Marukome0743 commented Jun 12, 2025

Thank you for a nice review!
As you say, I removed the typescript changes from this PR.
In addition, I have updated the PR title and description.

On the other hand, I will make the another typescript 24 PR.

Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@AlvaroRausell AlvaroRausell merged commit f4b0fee into devcontainers:main Jun 17, 2025
2 checks passed
@Marukome0743
Copy link
Contributor Author

YayYeahGIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants