Skip to content

[javascript-node, typescript-node] - Node 18 EOL changes. #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 11, 2025

Conversation

Kaniska244
Copy link
Contributor

Ref: #90

Devcontainer Image:

  • javascript-node
  • typescript-node

Description of changes:

  • Changes corresponding to Node 18 EOL effective on 30th Apr 2025, see here

Changelog:

  • Change in manifest.json & readme files to remove node 18 references for both javascript-node and typescript-node images.

Checklist:

  • Checked that applied changes work as expected

@Kaniska244 Kaniska244 marked this pull request as ready for review April 25, 2025 06:22
@Kaniska244 Kaniska244 requested a review from a team as a code owner April 25, 2025 06:22
@Kaniska244 Kaniska244 requested a review from ddoyle2017 April 25, 2025 14:21
@Mathiyarasy Mathiyarasy self-requested a review April 30, 2025 08:55
Mathiyarasy
Mathiyarasy previously approved these changes Apr 30, 2025
Copy link
Contributor

@AlvaroRausell AlvaroRausell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be a major version change? We would be breaking users that depend on Node 18 for their devcontainers

@Kaniska244
Copy link
Contributor Author

Should this not be a major version change? We would be breaking users that depend on Node 18 for their devcontainers

Hello @AlvaroRausell ,

I have updated the version to 1.2.0. Kindly let me know if this is fine.

@Kaniska244 Kaniska244 requested a review from AlvaroRausell June 6, 2025 07:54
@AlvaroRausell
Copy link
Contributor

@Kaniska244 A major version bump would have been to 2.0.0. Minor version changes i.e. 1.2.0 means added functionality whilst remaining backwards compatible, whereas 2.0.0 implies breaking changes - in this case loss of Node 18 compatibility.

@Eldogor447-ui
Copy link

**Ref.: ** #90

Imagen de Devcontainer:

  • nodo javascript
  • nodo de tipografía

Descripción de los cambios:

  • Cambios correspondientes al Nodo 18 EOL efectivo el 30 de abril de 2025, consulte aquí

Registro de cambios:

  • Cambio en los archivos manifest.json y readme para eliminar las referencias del nodo 18 tanto para las imágenes javascript-nodecomo para typescript-nodelas imágenes.

Lista de verificación:

  • Se verificó que los cambios aplicados funcionan como se esperaba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants