Skip to content

Fix flaky tests caused by relaxed load in C++ 'shared_ptr::use_count()' #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2020
Merged

Fix flaky tests caused by relaxed load in C++ 'shared_ptr::use_count()' #450

merged 2 commits into from
Sep 2, 2020

Conversation

@piscisaureus
Copy link
Member

@piscisaureus piscisaureus commented Aug 31, 2020 •
edited
Loading

No description provided.

piscisaureus added a commit to piscisaureus/safe_v8 that referenced this pull request Aug 31, 2020
@piscisaureus
Fix minor SharedPtr/SharedRef issues, and add unit tests (denoland#450)
ef8dec2 
* The `Default` trait did not actually get derived for `SharedPtr<T>`.
  This is solved by implementing `Default` manually.
* Trait function `Shared::get()` used to return a mutable raw pointer
  (`*mut Self`), but it would be inconceivable to ever mutate the
  referenced value. It was changed to return a const pointer instead.
* Added some basic unit tests for types `SharedPtr` and `SharedRef`.
piscisaureus added a commit to piscisaureus/safe_v8 that referenced this pull request Aug 31, 2020
@piscisaureus
Fix flakyness caused by C++ shared_ptr::use_count() relaxed load (d…
8c86eb8 
…enoland#450)

Fixes: denoland#284
@piscisaureus piscisaureus changed the title X Fix flaky tests due to C++ shared_ptr::use_count() relaxed load Aug 31, 2020
@piscisaureus piscisaureus changed the title Fix flaky tests due to C++ shared_ptr::use_count() relaxed load Fix flaky tests due to C++ 'shared_ptr::use_count()' using relaxed load Aug 31, 2020
piscisaureus added a commit to piscisaureus/safe_v8 that referenced this pull request Aug 31, 2020
@piscisaureus
Fix flaky tests due to C++ 'shared_ptr::use_count()' using relaxed lo…
ec0c5d4 
…ad (denoland#450)

Fixes: denoland#284
piscisaureus added a commit to piscisaureus/safe_v8 that referenced this pull request Aug 31, 2020
@piscisaureus
Fix flaky tests caused by relaxed load in C++ 'shared_ptr::use_count(…
4b31cbb 
…)' (denoland#450)

Fixes: denoland#284
@piscisaureus piscisaureus changed the title Fix flaky tests due to C++ 'shared_ptr::use_count()' using relaxed load Fix flaky tests caused by relaxed load in C++ 'shared_ptr::use_count()' Aug 31, 2020
@piscisaureus piscisaureus requested a review from ry August 31, 2020 06:29
@piscisaureus piscisaureus reopened this Aug 31, 2020
ry
ry reviewed Aug 31, 2020
View reviewed changes
ry
ry reviewed Aug 31, 2020
View reviewed changes
ry
ry reviewed Aug 31, 2020
View reviewed changes
@ry
Copy link
Member

ry commented Aug 31, 2020

Are we even using shared_ptr in a multithreaded way? I don't really understand what is happening here.

ry
ry approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but consider removing assert_use_count_eq from the public API

@piscisaureus
Copy link
Member Author

piscisaureus commented Sep 2, 2020 •
edited
Loading

Are we even using shared_ptr in a multithreaded way? I don't really understand what is happening here.

Theoretically the thread could be preempted, or a page fault could happen, in between dropping the shared_ptr reference and the call to use_count(), and then the thread resumes on a different core. However when reproducing this locally it happens often enough (about 1 in 100 times) that I don't believe this is happening.

My alternative theory is that this is what SPECTRE mitigation looks like.

@bnoordhuis I wonder if you have any theories...

@piscisaureus
Fix minor SharedPtr/SharedRef issues, and add unit tests (denoland#450)
d91970d 
* The `Default` trait did not actually get derived for `SharedPtr<T>`.
  This is solved by implementing `Default` manually.
* Trait function `Shared::get()` used to return a mutable raw pointer
  (`*mut Self`), but it would be inconceivable to ever mutate the
  referenced value. It was changed to return a const pointer instead.
* Added some basic unit tests for types `SharedPtr` and `SharedRef`.
@piscisaureus
Fix flaky tests caused by relaxed load in C++ 'shared_ptr::use_count(…
21f6ecf 
…)' (denoland#450)

Fixes: denoland#284
@piscisaureus piscisaureus merged commit 21f6ecf into denoland:master Sep 2, 2020
@piscisaureus piscisaureus deleted the shared branch September 2, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ry ry ry approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@piscisaureus @ry