Skip to content

Conversation

@littledivy
Copy link
Member

No description provided.

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that this is for perf

LGTM

@aapoalas
Copy link
Contributor

What is "handle zapping" actually?

@littledivy
Copy link
Member Author

littledivy commented Feb 11, 2023

@aapoalas IIUC zapping is rewriting a memory region with garbage (read it somewhere in a v8 issue).

-DENABLE_HANDLE_ZAPPING enables this bit of code: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/handles/handles.cc;l=182;bpv=1;bpt=1?q=ENABLE_HANDLE_ZAPPING&ss=chromium%2Fchromium%2Fsrc

Also relevant Node.js PR: nodejs/node#23801

@littledivy littledivy merged commit 6043e7d into denoland:main Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants