Skip to content

fix: upgrade deno_core to 0.355.0 #30352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

petamoriken
Copy link
Contributor

@petamoriken petamoriken commented Aug 7, 2025

@petamoriken
Copy link
Contributor Author

It seems there is still some kind of problem.

   Compiling deno_crypto v0.226.0 (/Users/runner/work/deno/deno/ext/crypto)
error: expected identifier, found keyword `ref`
   --> ext/node/ops/handle_wrap.rs:114:1
    |
114 | #[op2(inherit = AsyncWrap)]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected identifier, found keyword
    |
    = note: this error originates in the attribute macro `op2` (in Nightly builds, run with -Z macro-backtrace for more info)
help: escape `ref` to use it as an identifier
    |
114 | r##[op2(inherit = AsyncWrap)]
    | ++

error: expected identifier, found keyword `ref`
   --> ext/node/ops/handle_wrap.rs:114:1
    |
114 | #[op2(inherit = AsyncWrap)]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected identifier, found keyword
    |
    = note: this error originates in the attribute macro `op2` (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected type, found keyword `ref`
   --> ext/node/ops/handle_wrap.rs:114:1
    |
114 | #[op2(inherit = AsyncWrap)]
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected type
    |
    = note: this error originates in the attribute macro `op2` (in Nightly builds, run with -Z macro-backtrace for more info)

@bartlomieju
Copy link
Member

@littledivy could you please take a look?

@petamoriken petamoriken force-pushed the fix/update-deno-core branch from 0ef50de to 9aa5db6 Compare August 11, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants