fix(ext/fetch): only uppercase known methods #30290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me! And the addition of the null prototype for known methods is a good additional change. |
bartlomieju
reviewed
Aug 6, 2025
| @@ -222,7 +221,6 @@ const KNOWN_METHODS = { | |||
| "OPTIONS": "OPTIONS", | |||
| "options": "OPTIONS", | |||
| "PATCH": "PATCH", | |||
| "patch": "PATCH", | |||
There was a problem hiding this comment.
Is there a reason to remove this one?
There was a problem hiding this comment.
Yes. Without this change, patch would be converted to PATCH in the "fast case" of method normalization. PATCH is not on the list of methods which the fetch standard says should be normalized via uppercase. HTTP methods are case-sensitive, and patch and PATCH are not the same. You can test this by using fetch in Chrome.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30288.
@mitranim Please take a look to see if this is the correct fix.