fix(ext/node): use primordials in ext/node/polyfills/internal_binding/util.ts
#30014
+23
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ext/node/polyfills/internal_binding/util.ts`
petamoriken
reviewed
Jul 7, 2025
Comment on lines
106
to
109
| let allProperties = [ | ||
| ...Object.getOwnPropertyNames(obj), | ||
| ...Object.getOwnPropertySymbols(obj), | ||
| ...new SafeArrayIterator(ObjectGetOwnPropertyNames(obj)), | ||
| ...new SafeArrayIterator(ObjectGetOwnPropertySymbols(obj)), | ||
| ]; |
There was a problem hiding this comment.
It seems better to use Reflect.ownKeys.
let allProperties = ReflectOwnKeys(obj);There was a problem hiding this comment.
This makes sense. I've updated it. Thank you for your review!
Comment on lines
123
to
124
| for (const key of new SafeArrayIterator(allProperties)) { | ||
| const desc = ObjectGetOwnPropertyDescriptor(obj, key); |
There was a problem hiding this comment.
SafeArrayIterator has a slight performance cost, I would like to use a simple loop based on the index.
Suggested change
| for (const key of new SafeArrayIterator(allProperties)) { | |
| const desc = ObjectGetOwnPropertyDescriptor(obj, key); | |
| for (let i = 0; i < allProperties.length; ++i) { | |
| const key = allProperties[i]; | |
| const desc = ObjectGetOwnPropertyDescriptor(obj, key); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #24236. Replaces JS builtins with equivalent primordials.