feat(unstable): use Node.js setTimeout and setInterval
#29993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
reviewed
Jul 3, 2025
There was a problem hiding this comment.
make typechecking be conditional depending on this, most likely requires
changes in our TS fork.
Search for ts.deno.setNodeOnlyGlobalNames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit repurposes
--unstable-node-globalsflag that was deprecatedin #29887 to switch out timers implemention
that is used.
Ie. using this flag cause
setTimeout,setInterval,clearTimeoutandclearIntervalglobals to use functions from
node:timersmodule instead of the Web version.This is also enabled using
DENO_COMPAT=1env var.TODO:
make typechecking be conditional depending on this, most likely requires
changes in our TS fork.
Towards #29703