Skip to content

Conversation

@Nordalf
Copy link
Contributor

@Nordalf Nordalf commented Mar 5, 2025

Description

I did not want to modify the CommitInfo structure, but this would be ideal to expand the CommitInfo with a version property. But I am a little unsure how much it will break or whether a log can have multiple commit infos?

As an alternative, I want to propose this function to retrieve all versions of a table with related commit infos. Returned as a tuple of (Vec<i64>, Vec<CommitInfo>).

I am using it myself to figure out the versions available when restoring - without going into an object store.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Mar 5, 2025
@Nordalf Nordalf force-pushed the feat/get_all_versions branch from eca7ce6 to 82a1b8d Compare May 1, 2025 07:33
@codecov
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 72.54902% with 28 lines in your changes missing coverage. Please review.

Project coverage is 72.00%. Comparing base (131a6e2) to head (82a1b8d).

Files with missing lines Patch % Lines
crates/core/src/logstore/mod.rs 72.54% 19 Missing and 9 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3302    +/-   ##
========================================
  Coverage   71.99%   72.00%            
========================================
  Files         148      148            
  Lines       46082    46184   +102     
  Branches    46082    46184   +102     
========================================
+ Hits        33178    33254    +76     
- Misses      10789    10810    +21     
- Partials     2115     2120     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@roeap roeap added this to delta-rust Aug 8, 2025
@roeap roeap moved this to Ready in delta-rust Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

binding/rust Issues for the Rust crate

Projects

Status: Ready

Development

Successfully merging this pull request may close these issues.

1 participant