Skip to content

Conversation

prakashsurya
Copy link
Contributor

No description provided.

@prakashsurya
Copy link
Contributor Author

prakashsurya commented Aug 5, 2019

@prakashsurya
Copy link
Contributor Author

cc: @sdimitro @pzakha

Copy link
Contributor

@pzakha pzakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the gitlab repo was somewhat behind the github repo. Would be worth it to do a git-ab-pre-push as well once the linux-pkg-build is done. Looking at the differences, we do not seem to have a debian directory in there, so the build will most likely fail.

Also, do you have plans to setup auto-update for this repository?

Copy link
Contributor

@pzakha pzakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to request changes, not approve, due to github repository missing debian directory.

@prakashsurya
Copy link
Contributor Author

prakashsurya commented Aug 5, 2019

Would be worth it to do a git-ab-pre-push as well once the linux-pkg-build is done.

Yes, I can do this.

Also, do you have plans to setup auto-update for this repository?

No concrete plans, but I believe we do want to have it be automatically updated. I believe our plans are to use the same model for this repository, as we do for "delphix/zfs"; i.e. we interact directly with upstream, and use auto-merges to keep our fork up-to-date.

I don't know how this will be implemented, but I'd like to have that discussion elsewhere, since it's not directly related to this change.

@prakashsurya
Copy link
Contributor Author

@pzakha can you give this another look; I think it's ready to go.

@pzakha pzakha merged commit 7899cf8 into delphix:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants