TOOL-11725 drgn: fix python build dependencies #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don-brady
approved these changes
Jul 13, 2021
delphix-devops-bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
Add a new drgn.ObjectNotFoundError exception type to use for failed prog[], prog.object(), prog.variable(), prog.constant(), and prog.function() lookups. This has a few benefits: 1. It allows catching object lookup errors without the risk of catching a stray error from a dict or attribute lookup. See #28. 2. It allows us to have a more descriptive error message. See osandov#527. 3. It makes it possible to get the name that could not be found from the exception. It is a subclass of KeyError (and thus also of LookupError), so this should be backwards compatible. The implementation is inspired by AttributeError in CPython. If we end up liking this, we might want to do the same for object member lookups. Signed-off-by: Omar Sandoval <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepares drgn for Ubuntu 20.04, which uses a different version of python3 (3.8 vs 3.6).
Testing