Skip to content

Conversation

@Avenger-285714
Copy link
Member

Reverts #315

@Avenger-285714 Avenger-285714 merged commit 7318585 into linux-6.6.y Jul 11, 2024
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • nvkm_firmware_ctor函数中,fw->img的内存分配应该使用kmalloc而不是dma_alloc_coherent,以避免潜在的DMA错误。
  • dma_map_single函数的使用应该检查返回值,以确保内存映射成功。
  • kfree函数在内存映射失败时被调用,但是没有相应的注释说明为什么需要释放内存。
  • sg_init_one函数的使用应该确保fw->img已经被正确映射到设备。

是否建议立即修改:

@deepin-ci-robot deepin-ci-robot requested a review from myml July 11, 2024 07:16
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tsic404 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants