Skip to content

Conversation

@xuyan213
Copy link

Generic PWM framework driver for the PWM controller found on Phytium SoCs.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign goldendeng for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


return phytium_pwm_set_parameter(priv);
}
static int pwm_phytium_probe(struct platform_device *pdev)
Copy link
Member

@Avenger-285714 Avenger-285714 May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

少了个空行嘛

@xuyan213 xuyan213 force-pushed the pwm branch 2 times, most recently from 207ec6f to 3b300ac Compare June 27, 2024 08:24
@opsiff
Copy link
Member

opsiff commented Jun 27, 2024

在 X86 上编译错误 ,之前的ARM架构宏还需要保留
drivers/pwm/sysfs.c: In function ‘pwm_export_child’:
drivers/pwm/sysfs.c:264:13: error: implicit declaration of function ‘read_cpuid_implementor’ [-Werror=implicit-function-declaration]
264 | if (read_cpuid_implementor() == ARM_CPU_IMP_PHYTIUM)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/pwm/sysfs.c:264:41: error: ‘ARM_CPU_IMP_PHYTIUM’ undeclared (first use in this function)
264 | if (read_cpuid_implementor() == ARM_CPU_IMP_PHYTIUM)
| ^~~~~~~~~~~~~~~~~~~
drivers/pwm/sysfs.c:264:41: note: each undeclared identifier is reported only once for each function it appears in
cc1: all warnings being treated as errors

Generic PWM framework driver for the PWM controller found on
Phytium SoCs.

Signed-off-by: xu yan <[email protected]>
Signed-off-by: Chen Zhenhua <[email protected]>
Signed-off-by: Wang Yinfeng <[email protected]>
Signed-off-by: lanhengyu1395 <[email protected]>
@opsiff
Copy link
Member

opsiff commented Jul 1, 2024

/ok-to-test

@deepin-ci-robot
Copy link

deepin pr auto review

Add support for Phytium SoC PWM driver

git-svn-id: 0ff597fd157e6f4fc38580e8d64ab130330d241@2142 13273008-0d34-0410-b5e6-96231b3b80d8

@opsiff
Copy link
Member

opsiff commented Jul 1, 2024

剩余审查意见: read_cpuid_implementor方法在一个cpu中不同core有除了飞腾implementor时有其他implementor时可能失效,当前暂时无此种情况。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants