fix: url pattern build to handle optional paths #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tagging OptionsShould a new tag be published when this PR is merged?
|
mcandeia
approved these changes
Apr 10, 2025
Contributor
Author
|
without the PR on deco we have a crash on render when used both, optional path and search param |
matheusgr
approved these changes
Apr 17, 2025
guitavano
added a commit
that referenced
this pull request
Apr 23, 2025
This reverts commit ce27591.
guitavano
added a commit
that referenced
this pull request
Apr 23, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this Contribution About?
This PR fixes the URLPattern build to handle optional paths
https://developer.mozilla.org/en-US/docs/Web/API/URL_Pattern_API#group_delimiters
the old way scapes the group delimiters and read all '?' tokens as a search params, make the optional paths like:
/requiredPath{/optionalPath}?or/{optinalPath/}?requiredPath}not able to work once the{}are encoded and?read as a search param.This new way handle both, optional paths and search params
This PR also fix the paths ranking for optional paths
before this PR the ranking for optional paths were:
after:
https://www.loom.com/share/a51b17205b8f4100ab0280a215503cb7?sid=d6192642-5c85-4578-a1ea-990eb8ef496f
This PR Depends on this PR: deco#898