Fwd vip weight regression #198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoelker
force-pushed
the
fwd_vip_weight_regression
branch
from
054405d to
9e5d3c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 66.60% 66.02% -0.58%
==========================================
Files 55 55
Lines 3731 3759 +28
==========================================
- Hits 2485 2482 -3
- Misses 1246 1277 +31
Continue to review full report at Codecov.
|
jkoelker
force-pushed
the
fwd_vip_weight_regression
branch
from
dca2783 to
e8c4d88
Compare
jkoelker
force-pushed
the
fwd_vip_weight_regression
branch
from
e8c4d88 to
f8addb3
Compare
jkoelker
force-pushed
the
fwd_vip_weight_regression
branch
from
24aa5e0 to
ae2affe
Compare
Adds testing that the different backend selection and manupulation functions work with and without the weight being specified. Confirms that if an agent populates a VIP using the old code that the new code won't crash.
jkoelker
force-pushed
the
fwd_vip_weight_regression
branch
from
ae2affe to
dc8680e
Compare
wavesoft
approved these changes
Apr 22, 2020
wavesoft
left a comment
wavesoft
left a comment
There was a problem hiding this comment.
Per my review in the back-port : #197 (review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.d2iq.com/browse/COPS-6002
DCOS PR: dcos/dcos#7184