Skip to content

Conversation

@urbanserj
Copy link
Contributor

@urbanserj urbanserj requested a review from ichernetsky October 31, 2019 23:51
@codecov
Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #188 into master will increase coverage by 0.02%.
The diff coverage is 14.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   66.45%   66.47%   +0.02%     
==========================================
  Files          55       55              
  Lines        3756     3726      -30     
==========================================
- Hits         2496     2477      -19     
+ Misses       1260     1249      -11
Flag Coverage Δ
#ct 46.61% <2.94%> (+0.31%) ⬆️
#ct2 46.61% <2.94%> (+0.31%) ⬆️
#eunit 24.39% <11.76%> (-0.37%) ⬇️
Impacted Files Coverage Δ
apps/dcos_dns/src/dcos_dns_config.erl 88.57% <ø> (-0.32%) ⬇️
apps/dcos_dns/src/dcos_dns_listener.erl 35.71% <100%> (+2.38%) ⬆️
apps/dcos_dns/src/dcos_dns_mesos.erl 39.84% <12.12%> (-4.46%) ⬇️
apps/dcos_l4lb/src/dcos_l4lb_mgr.erl 80.19% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a48cdf9...37153ba. Read the comment docs.

@urbanserj urbanserj force-pushed the urbanserj/rm-store-modes branch from d33c5ec to 37153ba Compare November 4, 2019 20:26
@urbanserj urbanserj merged commit eb72421 into master Nov 4, 2019
@urbanserj urbanserj deleted the urbanserj/rm-store-modes branch November 4, 2019 21:44
@urbanserj urbanserj mentioned this pull request Nov 4, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants