Skip to content

Conversation

@ichernetsky
Copy link
Contributor

@ichernetsky ichernetsky commented Aug 20, 2019

JIRA issue: DCOS_OSS-5461

@ichernetsky ichernetsky self-assigned this Aug 20, 2019
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #177 into master will decrease coverage by 1.1%.
The diff coverage is 32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   67.94%   66.84%   -1.11%     
==========================================
  Files          55       55              
  Lines        3585     3640      +55     
==========================================
- Hits         2436     2433       -3     
- Misses       1149     1207      +58
Flag Coverage Δ
#ct 47.44% <27.33%> (-0.82%) ⬇️
#ct2 47.44% <27.33%> (-0.82%) ⬇️
#eunit 24.09% <5.33%> (-0.37%) ⬇️
Impacted Files Coverage Δ
apps/dcos_net/src/dcos_net_logger_h.erl 70% <ø> (+5%) ⬆️
apps/dcos_overlay/src/dcos_overlay_configure.erl 0% <0%> (ø) ⬆️
apps/dcos_net/src/dcos_net_killer.erl 34.09% <0%> (ø) ⬆️
apps/dcos_l4lb/src/dcos_l4lb_netns_watcher.erl 18.91% <0%> (ø) ⬆️
apps/dcos_dns/src/dcos_dns_zk_record_server.erl 34.28% <0%> (ø) ⬆️
apps/dcos_dns/src/dcos_dns_sup.erl 48.83% <0%> (ø) ⬆️
apps/dcos_dns/src/dcos_dns_key_mgr.erl 44.15% <0%> (ø) ⬆️
apps/dcos_dns/src/dcos_dns_router.erl 56.52% <0%> (-1.26%) ⬇️
apps/dcos_l4lb/src/dcos_l4lb_ipset_mgr.erl 67.82% <0%> (-1.21%) ⬇️
apps/dcos_dns/src/dcos_dns_config.erl 88.88% <100%> (ø) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3acd81...eb99285. Read the comment docs.

Copy link
Contributor

@urbanserj urbanserj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ichernetsky ichernetsky merged commit 7d4fb3f into master Aug 28, 2019
@ichernetsky ichernetsky deleted the inc/logger branch August 28, 2019 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants