Skip to content

Return types MsGraphAdmin breaking multiple functions #91

@ITMobilityControl

Description

@ITMobilityControl

A lot of the functions have the return type MsGraphAdmin, which breaks a lot of the functions because they return for example an array.

Example:

    public function findAttachments(string $id): MsGraphAdmin
    {
        return MsGraphAdmin::get('users/'.$this->userId.'/messages/'.$id.'/attachments');
    }

The get function returns an array, but because the return type of the findAttachments is MsGraphAdmin you get an error.

In this case it should be:

    public function findAttachments(string $id): array
    {
        return MsGraphAdmin::get('users/'.$this->userId.'/messages/'.$id.'/attachments');
    }

Are there any tests which can be ran? They should catch these problems before they get pushed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions