Test db permissions #160
Merged
Test db permissions #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istence when running migrations
kraftp
reviewed
Sep 29, 2025
cmd/dbos/cli_integration_test.go
Outdated
| { | ||
| name: "FunnySchema", | ||
| schemaName: "F8nny_sCHem@-n@m3", | ||
| dbRole: "notpostgres", |
Member
There was a problem hiding this comment.
Put some funny characters in the role to verify everything is quoted correctly
kraftp
reviewed
Sep 29, 2025
| output, err := cmd.CombinedOutput() | ||
| require.NoError(t, err, "Migrate command failed: %s", string(output)) | ||
| assert.Contains(t, string(output), "DBOS migrations completed successfully", "Output should confirm migration") | ||
| fmt.Println(string(output)) |
Member
There was a problem hiding this comment.
We also need to test the app actually works with the new role after the migration
Collaborator
Author
There was a problem hiding this comment.
The other tests do that (they'll use the role that's passed to the suite)
kraftp
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.