Handle DBOS operations as workflow steps #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
commented
Sep 11, 2025
| assert.Equal(t, WorkflowStatusCancelled, status.Status, "expected enqueued workflow status to be WorkflowStatusCancelled") | ||
|
|
||
| return "should-never-see-this", nil | ||
| return "", nil |
Collaborator
Author
There was a problem hiding this comment.
Now, GetStatus from within a workflow that was cancelled will return an error -- because the step checkpointing detects the workflow was cancelled.
kraftp
reviewed
Sep 11, 2025
maxdml
force-pushed
the
special-steps
branch
from
a4673d8 to
000c040
Compare
kraftp
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call DBOS operations inside
RunAsStepif within a workflow.One thing this PR had to fix is the forked workflow ID generation, which was at a higher level and not idempotent. The systemDB forkWorkflow now returns the forked workflow ID.