Fix comms durable sleeps #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…regardless of whether we sleep or not
maxdml
commented
Sep 9, 2025
Comment on lines
-2012
to
-2017
| if err != nil { | ||
| if err == pgx.ErrNoRows { | ||
| value = nil // Event still doesn't exist | ||
| } else { | ||
| return nil, fmt.Errorf("failed to query workflow event after wait: %w", err) | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
simplify: the zero value of an any value is already nil
maxdml
commented
Sep 9, 2025
kraftp
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recv/getEventskipped sleeping (e.g., a value was already found, during recovery)recvwould return an error if it recorded a timeout valuerecv(addresses Recv should handle context cancellation #86)