Remove temp install #108
Merged
Remove temp install #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qianl15
reviewed
Sep 4, 2025
| } | ||
|
|
||
| logger.Info("Postgres available", "url", fmt.Sprintf("postgresql://postgres:%s@localhost:5432", password)) | ||
| logger.Info("Postgres available", "url", fmt.Sprintf("postgres://postgres:%s@localhost:5432", password)) |
Member
There was a problem hiding this comment.
Why change this? I thought you want users to use postgresql not postgres
Collaborator
Author
There was a problem hiding this comment.
In most go library, postgres and postgresql are interchangeable. But with some, only postgres is valid. I've had a connection error a couple times because of a wrong driver name. To be honest I don't know which exact library we use(d) triggered the error, but I think this will be helpful for people importing these libraries.
kraftp
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgresqlinstead ofpostgresas the db driver