Skip to content

Conversation

@micha91
Copy link
Collaborator

@micha91 micha91 commented Jan 16, 2024

  • Upgrade openapi client generator
  • Upgrade model jinja template accordingly
  • Remove unnecessary custom jinja templates
  • Execute generator for Polarion 2310
    • The specification was adjusted, because an endpoint was documented syntactically wrong
    • The body content of the importXUnitTestResults endpoint must be changed to
          "content" : {
            "application/octet-stream" : {
              "schema" : {
                "type" : "string",
                "format": "binary"
              }
            }
          }
  • Adjust the client to not be affected by breaking changes in the generator

Copy link
Collaborator

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's only one comment.
After this: LGTM.

@ewuerger ewuerger self-requested a review January 17, 2024 11:20
Copy link
Collaborator

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good argumentation. LGTM.

@micha91 micha91 merged commit 8d50bb8 into main Jan 17, 2024
@ewuerger ewuerger deleted the polarion2310-upgrade branch January 17, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants