Skip to content

Conversation

@UziTech
Copy link

@UziTech UziTech commented Apr 18, 2018

This PR makes marked pass commonmark atx headers.

I moved the regular heading regex to pedantic which doesn't require a space between the # and the text.

@UziTech
Copy link
Author

UziTech commented Apr 18, 2018

The only atx example that doesn't pass is because of whitespace

CommonMark (ATX headings):
foo
    # bar

------

Expected:
<p>foo
# bar</p>

------

Marked:
<p>foo
    # bar</p>

@UziTech
Copy link
Author

UziTech commented Apr 24, 2018

@davisjam have you had a chance to take a look at this?

Copy link
Owner

@davisjam davisjam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks

@davisjam davisjam merged commit 4cc97f6 into davisjam:SonatypeReport Apr 25, 2018
@UziTech UziTech deleted the heading-correct branch February 19, 2019 20:14
davisjam pushed a commit that referenced this pull request Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants