Make Webport configurable #47
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me. Please can you update the README and add a section under "Run with Access-Control-Allow-Origin" to describe this new option. |
|
I've updated the readme, please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to change the port under which greenmail-http can be reached by setting the property
uk.co.bigsoft.greenmail.web_portFor this to work, the frontend now uses the current browser url.
This means that if the firewall permits, the frontend can now also be used from a different computer, since the backend url is no longer hardcoded to localhost:7000.
This would break frontend development with
yarn start, however setting "proxy" in package.json configures yarn to redirect all unknown request to this url.Therefore yarn start still works and there should also no longer be any CORS problems.