Skip to content

Conversation

zakasalaheddine
Copy link

@zakasalaheddine zakasalaheddine commented Sep 29, 2025

Feature Enhancement: Solo Object Array Values Support

This PR enhances the solo feature to accept string arrays as property values, enabling more flexible multi-value filtering while maintaining full backward compatibility.

Before

React Pivote

After

React Pivote after

Changes Made

  • Enhanced solo filtering logic to support both single strings and string arrays
  • Implemented OR logic for array values (matches any value in the array)
  • Added type validation to gracefully handle mixed value types
  • Maintained backward compatibility - all existing solo objects continue to work unchanged
  • Added comprehensive edge case handling for empty arrays, null values, etc.

closes #110

@zakasalaheddine zakasalaheddine force-pushed the 110-feat-solo-array-values-support branch 3 times, most recently from a5fe9df to a3531f6 Compare October 1, 2025 16:02
Copy link

@dawitmesfin12 dawitmesfin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +37 to +38
<option value={''}>{placeholder}</option>
{options.map(function (optionValue) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we be sure that options may not have the empty '' value?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikunjkumar-dhorajiya-interlincx empty value make sure we remove that item from the list of Solo Values, the Placeholder shows something like Remove value... and when the user select it and we have an empty value we remove that selected item

@zakasalaheddine zakasalaheddine force-pushed the 110-feat-solo-array-values-support branch from a3531f6 to ab723a8 Compare October 6, 2025 19:45
@zakasalaheddine zakasalaheddine force-pushed the 110-feat-solo-array-values-support branch from ab723a8 to d218ca0 Compare October 14, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Allow String Arrays as Values in Solo Feature

4 participants